[unbound] split the unbound service in two and don't use named ports #7597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No need for the named ports. Let's simplify things. We're mapping the unbound ports 1-to-1, i.e. service port 53 maps to unbound port 53, etc.
We can't reliably maintain the existing service if it's using the same port numbers for UDP and TCP. See [1]. Adding new ports would result in a borked service, potentially bringing the whole thing down. With one service per protocol the port numbers will be unique within the service, so we should be good. [1] kubernetes/kubernetes#39188
vssldmtrv
requested review from
galkindmitrii,
dhoeller,
mutax,
defo89,
mbrowny,
SoenkeL and
occamshatchet
as code owners
mbrowny
approved these changes
Dec 27, 2024
soenkegithub
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.